Extract websocket functionality that is common to both server and future client #2582
+638
−493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xemul Just a friendly ping. |
xemul
reviewed
Dec 24, 2024
p12tic
force-pushed
the
websocket-server-extract-common
branch
2 times, most recently
from
4c3bfeb to
f044136
Compare
|
@xemul Just a friendly ping. |
|
@xemul Just a friendly ping. As far as I'm aware this PR only needs merging, the review has already been done. |
p12tic
force-pushed
the
websocket-server-extract-common
branch
from
f044136 to
f3becb2
Compare
|
Rebased on top of latest master. |
|
Still conflicts |
p12tic
force-pushed
the
websocket-server-extract-common
branch
2 times, most recently
from
5f5c9ba to
19da320
Compare
p12tic
force-pushed
the
websocket-server-extract-common
branch
from
19da320 to
74c8730
Compare
|
@xemul Rebased again, should be good to merge. Thanks! |
This will allow to implement Websocket client that reuses existing code.
Current implementation of websocket connection is specific to the server. Rename to more appropriate name.
Websocket connection handling is mostly not specific to the server and thus can be reused on the client easily.
Previous name was useful when it's used locally in translation unit. The new name is exposed in a header and should be more unique.
This function will be useful on websocket client to construct Sec-WebSocket-Key header.
p12tic
force-pushed
the
websocket-server-extract-common
branch
from
74c8730 to
ba4d044
Compare
|
Rebased again. |
|
@xemul Just a friendly ping. The PR is ready for merging and was not merged in the past due to merge conflicts. |
|
@scylladb/seastar-maint hello maintainers, could you help review / merge this change? |
|
@xemul Just a friendly ping.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently websocket server embeds a lot of functionality that would be useful for websocket client. This PR extracts it into a form that is easier to reuse. The websocket client itself has been implemented in #2552.
This PR extracts parts of #2552 to make it easier to land.